Windows test package: print the shortcut target in UTF-8 (false error and unmasked user name in wintest-4) #39

Manually merged

SkyfaR merged 1 commit from windows-wintest-utf8 into main 2026-10-06 17:18:50 +02:00

Conversation 0 Commits 1 Files changed 1 +18 -4

SkyfaR commented 2026-10-06 17:08:03 +02:00

Owner

Copy link

A fix to the Windows test package, found in the real-PC run wintest-4 (ogc-messungen issue #7).

packaging/windows/test/lnk-aumid.c printed the shortcut's target with wprintf, so the target came out in the console's code page. run-tests.ps1 reads programs' output as UTF-8, so a profile folder with an accented user name came out garbled ("C:\Users\Ren� …"). Two things followed:

• The comparison with the expected target failed, which was a false error: the shortcut was right.
• The masking of the profile folder as %USERPROFILE% did not match, so the tester's user name stood in the report.

The helper now converts its two lines with WideCharToMultiByte(CP_UTF8) and writes them with WriteFile. notification-state.c already writes UTF-8.

Tests: in the container, packaging/windows/test/wine-test.sh (which reads shortcuts with the helper) and dist.sh with the app bundle pass. Wine's own profile has no accented name, so the accented case itself is checked only by the next real-PC run.

Everything else in wintest-4 worked on the real Windows 11 PC; see the issue.

A fix to the Windows test package, found in the real-PC run wintest-4 (ogc-messungen issue #7). `packaging/windows/test/lnk-aumid.c` printed the shortcut's target with `wprintf`, so the target came out in the console's code page. `run-tests.ps1` reads programs' output as UTF-8, so a profile folder with an accented user name came out garbled ("C:\Users\Ren� …"). Two things followed: - The comparison with the expected target failed, which was a false error: the shortcut was right. - The masking of the profile folder as `%USERPROFILE%` did not match, so the tester's user name stood in the report. The helper now converts its two lines with `WideCharToMultiByte(CP_UTF8)` and writes them with `WriteFile`. `notification-state.c` already writes UTF-8. **Tests:** in the container, `packaging/windows/test/wine-test.sh` (which reads shortcuts with the helper) and `dist.sh` with the app bundle pass. Wine's own profile has no accented name, so the accented case itself is checked only by the next real-PC run. Everything else in wintest-4 worked on the real Windows 11 PC; see the issue.

SkyfaR added 1 commit 2026-10-06 17:08:03 +02:00

Print the shortcut's target in UTF-8 in the Windows test helper ... 55f8c6119c

On the real PC, lnk-aumid.exe wrote a profile folder with an accented
user name in the console's code page, which run-tests.ps1 read as
UTF-8. The garbled path neither matched the expected one, a false
error, nor was masked as %USERPROFILE%, so the tester's user name stood
in the report. The helper now writes its lines as UTF-8 itself.

SkyfaR manually merged commit f13b6da6e2 into main 2026-10-06 17:18:50 +02:00

SkyfaR referenced this pull request from a commit 2026-10-06 17:18:52 +02:00

Merge pull request 'Windows test package: print the shortcut target in UTF-8 (false error and unmasked user name in wintest-4)' (#39) from windows-wintest-utf8 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

LevelXStudios/OpenGameCompressor!39

No description provided.